Add ExpressionTemplateValueProvider #17448
Open
+113
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
requested changes
Jul 23, 2025
...ringframework/security/core/annotation/ExpressionTemplateSecurityAnnotationScannerTests.java
Outdated
Show resolved
Hide resolved
.../main/java/org/springframework/security/core/annotation/ExpressionTemplateValueProvider.java
Outdated
Show resolved
Hide resolved
.../main/java/org/springframework/security/core/annotation/ExpressionTemplateValueProvider.java
Show resolved
Hide resolved
jzheaux
added
in: core
|
Hey Josh. Thanks for taking a look at my PR. It's been too long. We need to catch up sometime in more than just PR comments! |
spring-projects-issues
added
status: feedback-provided
jzheaux
approved these changes
Jul 31, 2025
jzheaux
force-pushed
the
mheath/expression_template_value_provider
branch
from
89988e4 to
ca58ca9
Compare
|
Thanks for the updates, @mheath. Are you able to sign your commit? (Note that I rebased, squashed, and added a polish commit before I noticed. Apologies, you may need to reset in order to push a change to your commit message.) |
Issue spring-projectsgh-17447 Signed-off-by: Josh Cummings <[email protected]>
mheath
force-pushed
the
mheath/expression_template_value_provider
branch
from
ca58ca9 to
cff5653
Compare
|
Yep. My commit is signed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a simple mechanism for providing custom expression template values from enums used in expression templates.
Closes gh-17447